If they are kind of the large capacity rotors, you can't beat the rainbird ones in my opinion. Still need to swap them out occasionally due to them not rotating right but they work pretty well.
pop ups seem to be pretty interchangeable but I do like the rainbird ones as well.