Miller probably gets the nod at #2 in the world golf rankings but Weir reached number 3 the year he won the Masters. The best golfer during his time at BYU was without a doubt Bobby Clampett but his professional career was less than stellar.
Of course the undisputed best LDS golfer ever is Billy Casper but he didn't play for BYU.