So my guess is its a mixture of melanosis and maybe some pinguecula/pterygium benign growth from sun exposure due to a lot of golfing and being outside. But I've seen some peoples eyes yellow due to chronic redness/subconjunctival hemorrhages that don't clear well. I'd guess that smoking has lead to a lot of redness and inflammation and that is playing into why his eyes appear so much darker then they used to