If he risks it, gets to the league, and doesn’t make a team, and is forced on a practice squad, then he’s not making much.
I bet he could make as much / more than that with NIL deals.
If his only goal is to play in the NFL, then sure, he should try. But I’ve known a few people who played on practice squads, and it’s not the best lifestyle. I bet he would rather play as a starting QB here at BYU than some random practice squad.