I have an example of taking a similar approach that didn’t work so well. I have a family member who played comp soccer growing up. Travelled all over for tournaments and their family’s life revolves around their soccer. She gets a scholarship and was runner up for freshman of the year. After one semester she dropped out of school entirely and lost her scholarship.
Sometimes families take that approach and the kid isn’t good enough for a scholarship, or they get burnt out and don’t want to continue in that field and keep their scholarship. I’m glad it worked well for your family. For others it might be best to do something like a 529 savings plan and contribute money over the years.